lkml.org 
[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRE: [PATCH] mtd: atmel_nand: fix access to 16 bit NAND devices
    From
    Date
    On Fri, 2012-02-03 at 09:05 +0530, Venu Byravarasu wrote:
    > I see a problem with atmel_read_buf16 & atmel_write_buf16 functions.
    > As they are calling __raw_readsw & __raw_writesw respectively, which
    > would cause panic in cases of 16 bit unaligned buffers.
    > However, the buf passed to these functions is of type u8* from
    > atmel_read_buf & atmel_write_buf functions.

    I think this is a valid concern. In theory, the NAND infrustructure must
    guarantee that the buffer is always of even length, and most probably it
    does, but we could add a WARN_ON(len & 1) statements in
    'atmel_read_buf()' and 'atmel_write_buf()'.

    And probably the type could indeed be changed.

    But these concerns should be addressed separately.

    --
    Best Regards,
    Artem Bityutskiy
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-02-03 06:33    [W:0.021 / U:1.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site