lkml.org 
[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH v6 1/3] seccomp: kill the seccomp_t typedef
    From
    On Thu, Feb 2, 2012 at 7:29 AM, Serge E. Hallyn
    <serge.hallyn@canonical.com> wrote:
    > Quoting Will Drewry (wad@chromium.org):
    >> Replaces the seccomp_t typedef with seccomp_struct to match modern
    >> kernel style.
    >
    > (sorry, I'm a bit behind on list)
    >
    > You were going to switch this to 'struct seccomp' right?

    I wasn;'t sure if

    task_struct {
    ...
    struct seccomp seccomp;
    }

    was as ideal. I've noticed that almost all of the duplicate names in
    the task struct use redundancy to differentiate the naming, but I'm
    happy enough to rename if appropriate.


    >> Signed-off-by: Will Drewry <wad@chromium.org>
    >> ---
    >>  include/linux/sched.h   |    2 +-
    >>  include/linux/seccomp.h |   10 ++++++----
    >>  2 files changed, 7 insertions(+), 5 deletions(-)
    >>
    >> diff --git a/include/linux/sched.h b/include/linux/sched.h
    >> index 4032ec1..288b5cb 100644
    >> --- a/include/linux/sched.h
    >> +++ b/include/linux/sched.h
    >> @@ -1418,7 +1418,7 @@ struct task_struct {
    >>       uid_t loginuid;
    >>       unsigned int sessionid;
    >>  #endif
    >> -     seccomp_t seccomp;
    >> +     struct seccomp_struct seccomp;
    >>
    >>  /* Thread group tracking */
    >>       u32 parent_exec_id;
    >> diff --git a/include/linux/seccomp.h b/include/linux/seccomp.h
    >> index cc7a4e9..171ab66 100644
    >> --- a/include/linux/seccomp.h
    >> +++ b/include/linux/seccomp.h
    >> @@ -7,7 +7,9 @@
    >>  #include <linux/thread_info.h>
    >>  #include <asm/seccomp.h>
    >>
    >> -typedef struct { int mode; } seccomp_t;
    >> +struct seccomp_struct {
    >> +     int mode;
    >> +};
    >>
    >>  extern void __secure_computing(int);
    >>  static inline void secure_computing(int this_syscall)
    >> @@ -19,7 +21,7 @@ static inline void secure_computing(int this_syscall)
    >>  extern long prctl_get_seccomp(void);
    >>  extern long prctl_set_seccomp(unsigned long);
    >>
    >> -static inline int seccomp_mode(seccomp_t *s)
    >> +static inline int seccomp_mode(struct seccomp_struct *s)
    >>  {
    >>       return s->mode;
    >>  }
    >> @@ -28,7 +30,7 @@ static inline int seccomp_mode(seccomp_t *s)
    >>
    >>  #include <linux/errno.h>
    >>
    >> -typedef struct { } seccomp_t;
    >> +struct seccomp_struct { };
    >>
    >>  #define secure_computing(x) do { } while (0)
    >>
    >> @@ -42,7 +44,7 @@ static inline long prctl_set_seccomp(unsigned long arg2)
    >>       return -EINVAL;
    >>  }
    >>
    >> -static inline int seccomp_mode(seccomp_t *s)
    >> +static inline int seccomp_mode(struct seccomp_struct *s)
    >>  {
    >>       return 0;
    >>  }
    >> --
    >> 1.7.5.4
    >>
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-04 00:19    [W:0.034 / U:1.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site