Messages in this thread | | | Date | Thu, 2 Feb 2012 22:34:36 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH] checkpatch: Check for quoted strings broken across lines |
| |
On Thu, Feb 02, 2012 at 09:27:27PM -0800, Josh Triplett wrote: > checkpatch already makes an exception to the 80-column rule for quoted > strings, and Documentation/CodingStyle recommends not splitting quoted > strings across lines, because it breaks the ability to grep for the > string. Rather than just permitting this, actively warn about quoted > strings split across lines. [...] > v2: Add the "after open parenthesis" heuristic which almost completely > eliminates non-user-visible strings, leaving only 12 in the entire > kernel, versus thousands of correct matches. Change "breaks > greppability" to "breaks the ability to grep for the string".
Sorry, forgot to change "PATCH" to "PATCHv2" in the subject.
- Josh Triplett
| |