[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC] killing boilerplate checks in ->link/->mkdir/->rename
    On Fri, Feb 03, 2012 at 01:16:12AM +0000, Al Viro wrote:
    > On Thu, Feb 02, 2012 at 03:46:06PM -0800, Linus Torvalds wrote:
    > > On Thu, Feb 2, 2012 at 1:24 PM, Al Viro <> wrote:
    > > >
    > > > Comments? ?Boilerplate removal follows (22 files changed, 45 insertions(+),
    > > > 120 deletions(-)), but it's *not* for immediate merge; it's really completely
    > > > untested.
    > >
    > > Looks ok to me. Historically, the more things we can check at the VFS
    > > layer, the better.
    > * what's up with btrfs_insert_inode_ref()? I've tried to trace
    > the codepaths around there, but...

    Btrfs stores backrefs (the filename, directory inode number) from the
    inode to the directory.

    In the current format that's a pretty low limit on how many of these we
    can store for hard links to the same file in the same directory, but
    basically no limit on how many backrefs we can store to the same file
    from different directories.

    Mark Fasheh was working on a patch to change the backrefs to make the
    links-from-the-same-dir case consistent with the
    links-from-different-dir case. With today's code, we'll go -EMLINK at
    different times depending on the length of the file name and what links
    you've already made.

    > Incidentally, when could fixup_low_keys()
    > return non-zero? I don't see any candidates for that in there... Chris?

    A long time ago this one used to cow blocks and so it needed an error
    return. I think Jeff Mahoney has a patch queued up to make it (among
    many others) void.


     \ /
      Last update: 2012-02-03 16:01    [W:0.020 / U:3.784 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site