[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf
On Thu, 2012-02-02 at 19:14 +0100, Frederic Weisbecker wrote:

> All the above from perf_ftrace_function_call() to here should perhaps
> go to trace_function.c.

Please no. This is a perf specific call into the function tracer.
Unless it is rewritten to be a completely generic function. As with the
normal rational on "generic" vs "specific" in the kernel. When there's
only one user, then keep it "specific". When we get two or more users,
then it can be converted to be generic.

Please do not put this into trace_function.c, as the only user of it is

-- Steve

 \ /
  Last update: 2012-02-03 14:57    [W:0.171 / U:22.848 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site