Messages in this thread | | | Date | Wed, 29 Feb 2012 16:13:56 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock |
| |
On 02/29/2012 03:51 PM, Joshua C. wrote: > > Will this work? > > +#if (defined(__i386__) || defined(__x86_64__)) > +#include <asm/io.h> > +#include <asm/setup.h> > +#else > +extern struct boot_params boot_params; > +#endif >
A much better way to do this is probably something like
#ifdef CONFIG_X86
#include <asm/setup.h>
static inline int kbd_defleds(void) { return boot_param.kbd_status & 0x20 ? (1 << VC_NUMLOCK) : 0; }
#elif defined(CONFIG_PARISC) static inline int kbd_defleds(void) { # if defined(CONFIG_KEYBOARD_HIL) || defined(CONFIG_KEYBOARD_HIL_OLD) return 1 << VC_NUMLOCK; # else return 0; # endif }
#else
static inline int kbd_defleds(void) { return 0; }
#endif
... then arguably this should be moved into the arch/* directories, in a header file or by making this a callable function.
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |