lkml.org 
[lkml]   [2012]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] powerpc/44x: Add more changes for APM821XX EMAC driver
From
From: Josh Boyer <jwboyer@gmail.com>
Date: Wed, 29 Feb 2012 08:43:46 -0500

> On Fri, Feb 17, 2012 at 3:07 AM, Duc Dang <dhdang@apm.com> wrote:
>> This patch includes:
>>
>>  Configure EMAC PHY clock source (clock from PHY or internal clock).
>>
>>  Do not advertise PHY half duplex capability as APM821XX EMAC does not
>> support half duplex mode.
>>
>>  Add changes to support configuring jumbo frame for APM821XX EMAC.
>>
>> Signed-off-by: Duc Dang <dhdang@apm.com>
>
> This should have been sent to netdev. CC'ing them now.
>
> Ben and David, I can take this change through the 4xx tree if it looks OK to
> both of you. The pre-requisite DTS patch will go through my tree, so it might
> make sense to keep them together.

Well the patch has coding style problems, for one:

>> + dev->features |= (EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE
>> + | EMAC_FTR_APM821XX_NO_HALF_DUPLEX
>> + | EMAC_FTR_460EX_PHY_CLK_FIX);

Should be:

>> + dev->features |= (EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE |
>> + EMAC_FTR_APM821XX_NO_HALF_DUPLEX |
>> + EMAC_FTR_460EX_PHY_CLK_FIX);

And this:

>> + dev->phy_feat_exc = (SUPPORTED_1000baseT_Half
>> + | SUPPORTED_100baseT_Half
>> + | SUPPORTED_10baseT_Half);

Should be:

>> + dev->phy_feat_exc = (SUPPORTED_1000baseT_Half |
>> + SUPPORTED_100baseT_Half |
>> + SUPPORTED_10baseT_Half);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-02-29 19:29    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site