Messages in this thread | | | Date | Wed, 29 Feb 2012 10:37:28 -0300 | Subject | Re: [PATCH] dma: imx-sdma: Add error check on sdma_get_firmware | From | Fabio Estevam <> |
| |
On Wed, Feb 29, 2012 at 5:38 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote: ... >> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c >> index bf736ad..52a4e6a 100644 >> --- a/drivers/dma/imx-sdma.c >> +++ b/drivers/dma/imx-sdma.c >> @@ -1388,7 +1388,11 @@ static int __init sdma_probe(struct platform_device *pdev) >> sdma_add_scripts(sdma, pdata->script_addrs); >> >> if (pdata) { >> - sdma_get_firmware(sdma, pdata->fw_name); >> + ret = sdma_get_firmware(sdma, pdata->fw_name); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to get firmware from pdata\n"); >> + goto err_init; >> + } > > No, you shouldn't bail out here. A failure in sdma_get_firmware only > means that we don't have the RAM scripts, but we can continue with the > ROM scripts and still do useful things in the driver.
Ok, the dt case also does a "goto err_init" and I just followed it on the pdata case.
So I plan to do the following:
1. Send a patch for removing the "goto err_init" from the sdma_get_firmware error check in the dt case 2. Send a patch that adds the error check for the pdata case.
Regards,
Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |