Messages in this thread | | | Date | Tue, 28 Feb 2012 15:27:31 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] uprobes/core: handle breakpoint and signal step exception. |
| |
* Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:
> > > The current unregistering thread waits till all other > > > threads that have hit a breakpoint to acquire the > > > uprobes_treelock before the uprobe is removed from the > > > rbtree. > > > > s/is removed/are removed > > > > ? > > > > At a time, we are unregistering just one probe,(atleast for > now.) Wondering if "before uprobes are remove from rbtree." > sounds as if more than one uprobe is being removed at one > instance.
The sentence still does not parse:
" X waits until Ys that have done Z before A is removed from the rbtree"
Did you want to say:
" The current unregistering thread waits till all other threads have hit a breakpoint, to acquire the uprobes_treelock before the uprobe is removed from the rbtree. "
(I have removed 'that' and added a comma.)
Thanks,
Ingo
| |