lkml.org 
[lkml]   [2012]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
    From
    Date
    On Tue, 2012-02-28 at 01:06 -0500, Mike Frysinger wrote:
    > On Monday 27 February 2012 22:17:01 James Bottomley wrote:
    > > On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
    > > > On Monday 27 February 2012 17:03:10 James Bottomley wrote:
    > > > > --- a/arch/parisc/Makefile
    > > > > +++ b/arch/parisc/Makefile
    > > > >
    > > > > -CROSS_COMPILE := hppa64-linux-gnu-
    > > > > +
    > > > > +# if no default set, try to find the corresponding 64 bit compiler
    > > > > +ifeq ($(CROSS_COMPILE),)
    > > > > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed
    > > > > s/hppa-\\\(.*\\\)/hppa64-\\1-/) +endif
    > > >
    > > > fails when using "hppa2.0-xxx". perhaps:

    Is that a valid prefix? I was thinking hppa32 might be, but hppa2.0 is
    supposed to be hppa-xxx with -mpa-risc-2-0.

    But anyway, I think being clever and removing unused stuff is likely
    orthogonal to the first patch which is just making it all work.

    > > > CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed
    > > > 's/^hppa[^-]*-/hppa64-/')
    > > >
    > > > don't even need the ifeq check then
    > >
    > > How is that different from Carlos' suggestion?
    >
    > sorry, but i'm not seeing any e-mails from Carlos in this thread. what is his
    > suggestion ?

    Actually, I misspoke, it was your suggestion in the first thread.

    > > The reason it doesn't work is the same ... CROSS_COMPILE is defined to be
    > > empty.
    >
    > my suggestion was purely an incremental improvement on the patch you posted.
    > it improves two things:
    > - detection when the default tuple is hppa2.0-xxx rather than hppa-xxx
    > - one line for set-variable-only-when-its-unset rather than three lines
    > -mike

    It can't be done ... defined but empty is different from not defined in
    makefiles (ifdef or ?= only checks for not defined). CROSS_COMPILE gets
    automatically defined by the top level Makefile ... that's why we need a
    check for empty not a check for not defined.

    James




    \
     
     \ /
      Last update: 2012-02-28 15:13    [W:0.023 / U:1.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site