lkml.org 
[lkml]   [2012]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpumask: fix lg_lock/br_lock.
On Mon, Feb 27, 2012 at 03:53:38PM -0800, Andrew Morton wrote:
> On Tue, 28 Feb 2012 09:52:30 +1030
> Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> > Use a cpumask_var_t instead of cpumask_t. We're doing plenty of
> > allocations here anyway, so it's not really an issue, and it sets a
> > good example.
> >
> > (cpumask_t is obsolescent, as are the cpus_* functions).
>
> Congratulations to yourself and Andi:

Well the only way to avoid that problem is to merge it ASAP.

The patch -- like most code movement patches -- is totally unsuitable for
keeping around for months in trees.

Usually I found the best way to do merges with code movement patches
is to edit the patches itself if possible.

Maybe some day we'll get patch like tools that can deal with this stuff
better.

Rusty: you should probably have cocci rules for this stuff, not manual
patches.

-Andi


\
 
 \ /
  Last update: 2012-02-28 12:27    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site