lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 64/72] builddeb: Dont create files in /tmp with predictable names
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <ben@decadent.org.uk>

    commit 6c635224602d760c1208ada337562f40d8ae93a5 upstream.

    The current use of /tmp for file lists is insecure. Put them under
    $objtree/debian instead.

    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Acked-by: maximilian attems <max@stro.at>
    Signed-off-by: Michal Marek <mmarek@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    scripts/package/builddeb | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    --- a/scripts/package/builddeb
    +++ b/scripts/package/builddeb
    @@ -238,14 +238,14 @@ EOF
    fi

    # Build header package
    -(cd $srctree; find . -name Makefile -o -name Kconfig\* -o -name \*.pl > /tmp/files$$)
    -(cd $srctree; find arch/$SRCARCH/include include scripts -type f >> /tmp/files$$)
    -(cd $objtree; find .config Module.symvers include scripts -type f >> /tmp/objfiles$$)
    +(cd $srctree; find . -name Makefile -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
    +(cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
    +(cd $objtree; find .config Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
    destdir=$kernel_headers_dir/usr/src/linux-headers-$version
    mkdir -p "$destdir"
    -(cd $srctree; tar -c -f - -T /tmp/files$$) | (cd $destdir; tar -xf -)
    -(cd $objtree; tar -c -f - -T /tmp/objfiles$$) | (cd $destdir; tar -xf -)
    -rm -f /tmp/files$$ /tmp/objfiles$$
    +(cd $srctree; tar -c -f - -T "$objtree/debian/hdrsrcfiles") | (cd $destdir; tar -xf -)
    +(cd $objtree; tar -c -f - -T "$objtree/debian/hdrobjfiles") | (cd $destdir; tar -xf -)
    +rm -f "$objtree/debian/hdrsrcfiles" "$objtree/debian/hdrobjfiles"
    arch=$(dpkg --print-architecture)

    cat <<EOF >> debian/control



    \
     
     \ /
      Last update: 2012-02-28 02:15    [W:0.049 / U:60.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site