lkml.org 
[lkml]   [2012]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] mm: add a low limit to alloc_large_system_hash
From
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 27 Feb 2012 07:03:17 +0100

> UDP stack needs a minimum hash size value for proper operation and also
> uses alloc_large_system_hash() for proper NUMA distribution of its hash
> tables and automatic sizing depending on available system memory.
>
> On some low memory situations, udp_table_init() must ignore the
> alloc_large_system_hash() result and reallocs a bigger memory area.
>
> As we cannot easily free old hash table, we leak it and kmemleak can
> issue a warning.
>
> This patch adds a low limit parameter to alloc_large_system_hash() to
> solve this problem.
>
> We then specify UDP_HTABLE_SIZE_MIN for UDP/UDPLite hash table
> allocation.
>
> Reported-by: Mark Asselstine <mark.asselstine@windriver.com>
> Reported-by: Tim Bird <tim.bird@am.sony.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Acked-by: David S. Miller <davem@davemloft.net>

Who wants to take this?



\
 
 \ /
  Last update: 2012-02-27 07:49    [from the cache]
©2003-2011 Jasper Spaans