| Date | Sun, 26 Feb 2012 19:04:28 -0500 | From | Ted Ts'o <> | Subject | Re: [PATCH 66/73] ext2: Split ext2_add_entry() from ext2_add_link() [ver #2] |
| |
On Tue, Feb 21, 2012 at 06:05:46PM +0000, David Howells wrote: > From: Valerie Aurora <vaurora@redhat.com> > > Allow future code to use the guts of ext2_add_link(). > > Original-author: Valerie Aurora <vaurora@redhat.com> > Signed-off-by: David Howells <dhowells@redhat.com> > Cc: Jan Kara <jack@suse.cz> > Cc: linux-ext4@kernel.org
I'd suggest folding this in with the following patch (67/73). It's not clear from this patch why renaming ext2_add_link to ext2_add_entry() makes sense and then adding a new ext2_add_link() which calls ext_add_entry(). It doesn't seem to clarify much....
I won't insist on it, but this seems to be unnecessary complication.
- Ted
|