lkml.org 
[lkml]   [2012]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL
    From
    2012/2/24 Michał Mirosław <mirqus@gmail.com>:
    > 2012/2/24 Danny Kukawka <danny.kukawka@bisect.de>:
    >> Second Part of series patches to unifiy the return value of
    >> .ndo_set_mac_address if the given address isn't valid.
    >>
    >> These changes check if a given (MAC) address is valid in
    >> .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL
    >> as eth_mac_addr() already does if is_valid_ether_addr() fails.
    >
    > Why not just fix dev_set_mac_address() and make do_setlink() use that?

    BTW, it's also called from dev_set_mac_address().

    > Checks are specific to address family, not device model I assume.

    Indeed, why can't this be done in one single place, instead of sprinkling these
    checks over all drivers, missing all out-of-tree (note: I don't care) and all
    soon-to-be-submitted drivers?

    Gr{oetje,eeting}s,

                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-25 11:15    [W:0.021 / U:121.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site