lkml.org 
[lkml]   [2012]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ARM: LPC32xx: Ethernet driver
Hi Roland,

On Sat, Feb 25, 2012 at 09:21:44PM +0100, Roland Stigge wrote:
> This patch adds an ethernet driver for the LPC32xx ARM SoC.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>

[snip]

> +static int __init ethaddr(char *s)
> +{
> + int i;
> + unsigned int r[6];
> +
> + sscanf(s, "%x:%x:%x:%x:%x:%x",
> + &r[0], &r[1], &r[2], &r[3], &r[4], &r[5]);
> + for (i = 0; i < 6; i++)
> + mac_address[i] = (u8)r[i];
> +
> + return 1;
> +}
> +__setup("ethaddr=", ethaddr);

Please use a module_param() instead of a top level kernel parameter.

You may also consider using module_param_array() here. See
drivers/net/ethernet/freescale/fec.c for an example. Note, however, that this
changes the format the MAC address representation. Instead of
"01:02:03:04:05:06", use "0x01,0x02,0x03,0x04,0x05,0x06".

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


\
 
 \ /
  Last update: 2012-02-26 03:21    [W:0.033 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site