lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] perf report: Add a simple GTK2-based 'perf report' browser
From
On Fri, Feb 24, 2012 at 11:48 AM, Ingo Molnar <mingo@elte.hu> wrote:
> * Pekka Enberg <penberg@kernel.org> wrote:
>
>> On Thu, Feb 23, 2012 at 10:33 PM, Colin Walters <walters@verbum.org> wrote:
>> >> Sure. We don't want to do that for all files. Just for the ones that
>> >> include <gtk/gtk.h>.
>> >
>> > #pragma GCC diagnostic push
>> > #pragma GCC diagnostic ignored "-Wstrict-prototypes"
>> > #include <gtk/gtk.h>
>> > #pragma GCC diagnostic pop
>>
>> It's cleaner to do it at Makefile level. We should do
>> something like sparse.git Makefile does where you can
>> optionally specify CFLAGS for individual source files.
>
> I actually like the #pragma hack because it only turns off the
> check for that broken header and keeps our checks in place for
> the rest of the .c file.
>
> Could be turned into a util/gtk.h file that is included instead
> of <gtk/gtk.h>, so that we don't have to see the #pragma
> workaround all the time?

Sure, makes sense.


\
 
 \ /
  Last update: 2012-02-24 11:09    [W:0.068 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site