Messages in this thread | | | Date | Fri, 24 Feb 2012 09:49:50 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] x86-64: Fix CFI data for common_interrupt |
| |
>>> On 21.02.12 at 23:08, Mark Wielaard <mjw@redhat.com> wrote: > On Tue, Feb 21, 2012 at 03:26:30PM +0000, Jan Beulich wrote: >> But provided the specification mandates this, I'm okay with the change >> in principle. Just that specifying an offset of 0 doesn't look right then. > > Yeah, I dunno what I was thinking. The offset should be set to the offset > that was there before when rsi was pushed. The attached patch does that > by using the same value as was used at the start of common_interrupt. > Does that look OK?
As written before, it ought to be
CFI_DEF_CFA rsi,SS+8-RBP /* reg/off reset after def_cfa_expr */
With that, feel free to add
Acked-by: Jan Beulich <jbeulich@suse.com>
when you re-submit.
Jan
| |