Messages in this thread | | | From | Michał Mirosław <> | Date | Fri, 24 Feb 2012 18:59:04 +0100 | Subject | Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL |
| |
2012/2/24 Danny Kukawka <danny.kukawka@bisect.de>: > Second Part of series patches to unifiy the return value of > .ndo_set_mac_address if the given address isn't valid. > > These changes check if a given (MAC) address is valid in > .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL > as eth_mac_addr() already does if is_valid_ether_addr() fails.
Why not just fix dev_set_mac_address() and make do_setlink() use that? Checks are specific to address family, not device model I assume.
Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |