[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH] fix move/migrate_pages() race on task struct
    On Fri, 24 Feb 2012, Dave Hansen wrote:

    > On 02/24/2012 07:20 AM, Christoph Lameter wrote:
    > > Subject: migration: Do not do rcu_read_unlock until the last time we need the task_struct pointer
    > >
    > > Migration functions perform the rcu_read_unlock too early. As a result the
    > > task pointed to may change. Bugs were introduced when adding security checks
    > > because rcu_unlock/lock sequences were inserted. Plus the security checks
    > > and do_move_pages used the task_struct pointer after rcu_unlock.
    > >
    > > Fix those issues by removing the unlock/lock sequences and moving the
    > > rcu_read_unlock after the last use of the task struct pointer.
    > >
    > > Signed-off-by: Christoph Lameter <>
    > It doesn't fix the code duplication, but it definitely does fix the bug

    Yes I did not want to override all your good work.

    Could you do another patch that removed the duplication?

     \ /
      Last update: 2012-02-24 17:57    [W:0.021 / U:5.644 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site