Messages in this thread Patch in this message | | | From | Danny Kukawka <> | Subject | [PATCH 12/12] rose: check given MAC address, if invalid return -EADDRNOTAVAIL | Date | Fri, 24 Feb 2012 17:01:22 +0100 |
| |
Check if given address is valid in .ndo_set_mac_address/ rose_set_mac_address(), if invalid return -EADDRNOTAVAIL as eth_mac_addr() already does if is_valid_ether_addr() fails.
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> --- net/rose/rose_dev.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/rose/rose_dev.c b/net/rose/rose_dev.c index 178ff4f..1ae8791 100644 --- a/net/rose/rose_dev.c +++ b/net/rose/rose_dev.c @@ -96,6 +96,9 @@ static int rose_set_mac_address(struct net_device *dev, void *addr) struct sockaddr *sa = addr; int err; + if (!is_valid_ether_addr(sa->sa_data)) + return -EADDRNOTAVAIL; + if (!memcpy(dev->dev_addr, sa->sa_data, dev->addr_len)) return 0; -- 1.7.8.3
| |