lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces
On Fri, Feb 24, 2012 at 02:41:04PM +0800, meng zhang wrote:
> from: Meng Zhang <meng.zhang@mediatek.com>
>
> 1. This patch is based on kernel 3.0.0

That is quite old, please make it against Linus's latest git tree if
possible, and if not, against 3.3-rc4. And if not that, how about 3.3?

> 2. To declare the product IDs in option.c
>
> Signed-off-by: Meng Zhang <meng.zhang@mediatek.com>
> ---------------------------------------------------------------------------------------
>
> --- option.c 2012-02-23 10:42:40.635138657 +0800
> +++ option.c.orig 2011-10-07 22:50:04.000000000 +0800

Hm, I think you didn't read Documentation/SubmittingPatches for the
correct patch level to send things. Please fix this as our automated
tools can not handle this patch

> @@ -416,9 +416,6 @@ static void option_instat_callback(struc
> #define SAMSUNG_VENDOR_ID 0x04e8
> #define SAMSUNG_PRODUCT_GT_B3730 0x6889
>
> -/* MediaTek products */
> -#define MEDIATEK_VENDOR_ID 0x0e8d
> -
> /* some devices interfaces need special handling due to a number of reasons */
> enum option_blacklist_reason {
> OPTION_BLACKLIST_NONE = 0,
> @@ -1008,10 +1005,6 @@ static const struct usb_device_id option
> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> CDMA 450 1xEVDO modem */

Your patch is also linewrapped, making it impossible to apply :(

Care to try this again after fixing it?

greg k-h


\
 
 \ /
  Last update: 2012-02-24 16:47    [W:0.065 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site