Messages in this thread | | | From | Rabin Vincent <> | Date | Fri, 24 Feb 2012 20:12:11 +0530 | Subject | Re: [PATCH] gpio/gpio-stmpe: Fix the value returned by _get_value routine |
| |
On Fri, Feb 24, 2012 at 19:59, viresh kumar <viresh.linux@gmail.com> wrote: > On Feb 24, 2012 7:46 PM, "Rabin Vincent" <rabin@rab.in> wrote: >> On Fri, Feb 24, 2012 at 16:04, Viresh Kumar <viresh.kumar@st.com> wrote: >> > The present _get_value routine returns the contents of the GPIO >> > Monitor Pin Status Register(GPMR) starting from the bit whose value >> > is requested to BIT 0. >> > >> > For e.g. if we request the value of GPIO 6 in the earlier >> > implementation the value returned is: >> > >> > BIT6 to BIT0 >> > >> > whereas it should just return BIT6. >> >> The current implementation just returns (ret & mask) where mask >> would have only BIT6 set, so how can it return "BIT6 to BIT0" ? > > Oops! I gave same comment when i saw this patch > on our internal list and i forgot to fix log while applying. > > It actually returns 0b1000000 for example. And we need 1 here.
According to the documentation, gpio_get_value() (i.e. this function) can return zero or non-zero, not necessarily zero or one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |