lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver
On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote:
> Hi Aneesh,
>

[...]

>> +struct emif_data {
>> + u8 duplicate;
>> + u8 temperature_level;
>> + u32 irq;
>> + spinlock_t lock; /* lock to prevent races */
>
> Nit: That comment is useless, since you already have the kerneldoc comment before.

Now I remember why I did that. Without that comment checkpatch gives
this "check".

CHECK: spinlock_t definition without comment
#124: FILE: drivers/misc/emif.c:54:
+ spinlock_t lock;

br,
Aneesh


\
 
 \ /
  Last update: 2012-02-24 12:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site