lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] IA64: simserial, bail out when request_irq fails
    Date
    Without this, the code succeeds when the port is opened by root and we
    get unwanted interrupts storm on the first key stroke.

    Instead of that, tell the user we failed and that we won't continue. I
    suppose, the code was copied from the serial layer where we may want
    to change the irq number, so we must allow open even of the failing
    port. This is not the case for this driver at all.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    arch/ia64/hp/sim/simserial.c | 9 +--------
    1 files changed, 1 insertions(+), 8 deletions(-)

    diff --git a/arch/ia64/hp/sim/simserial.c b/arch/ia64/hp/sim/simserial.c
    index 797e89a..60c9093 100644
    --- a/arch/ia64/hp/sim/simserial.c
    +++ b/arch/ia64/hp/sim/simserial.c
    @@ -702,15 +702,8 @@ startup(struct async_struct *info)
    handler = rs_interrupt_single;

    retval = request_irq(state->irq, handler, IRQ_T(info), "simserial", NULL);
    - if (retval) {
    - if (capable(CAP_SYS_ADMIN)) {
    - if (info->tty)
    - set_bit(TTY_IO_ERROR,
    - &info->tty->flags);
    - retval = 0;
    - }
    + if (retval)
    goto errout;
    - }
    }

    /*
    --
    1.7.9



    \
     
     \ /
      Last update: 2012-02-24 12:13    [W:0.020 / U:95.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site