lkml.org 
[lkml]   [2012]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 03/10] i387: fix sense of sanity check
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Linus Torvalds <torvalds@linux-foundation.org>

    commit c38e23456278e967f094b08247ffc3711b1029b2 upstream.

    The check for save_init_fpu() (introduced in commit 5b1cbac37798: "i387:
    make irq_fpu_usable() tests more robust") was the wrong way around, but
    I hadn't noticed, because my "tests" were bogus: the FPU exceptions are
    disabled by default, so even doing a divide by zero never actually
    triggers this code at all unless you do extra work to enable them.

    So if anybody did enable them, they'd get one spurious warning.

    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/include/asm/i387.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/include/asm/i387.h
    +++ b/arch/x86/include/asm/i387.h
    @@ -404,7 +404,7 @@ static inline void irq_ts_restore(int TS
    */
    static inline void save_init_fpu(struct task_struct *tsk)
    {
    - WARN_ON_ONCE(task_thread_info(tsk)->status & TS_USEDFPU);
    + WARN_ON_ONCE(!(task_thread_info(tsk)->status & TS_USEDFPU));
    preempt_disable();
    __save_init_fpu(tsk);
    stts();



    \
     
     \ /
      Last update: 2012-02-24 01:11    [W:0.020 / U:90.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site