lkml.org 
[lkml]   [2012]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] mempool, percpu, blkcg: fix percpu stat allocation and remove stats_lock
On Thu, 23 Feb 2012 15:12:04 -0800
Tejun Heo <tj@kernel.org> wrote:

> On Thu, Feb 23, 2012 at 03:01:23PM -0800, Tejun Heo wrote:
> > Hmmm... going through the thread again, ah, okay, I forgot about that
> > completely. Yeah, that is an actual problem. Both __GFP_WAIT which
> > isn't GFP_KERNEL and GFP_KERNEL are valid use cases. I guess we'll be
> > building async percpu pool in blkcg then. Great. :(
>
> Vivek, you win. :) Can you please refresh the async alloc patch on top
> of blkcg-stacking branch? I'll rool that into this series and drop
> the mempool stuff.

I forget how those patches work, but they might be vulnerable to the
same issue. If the block layer can handle the failed allocation
attempt and retry at the next I/O event then I guess that would be
acceptable; we'd lose a bit of statistical info occasionally, but who
cares.

But ISTR that we can't handle allocation failures here?


\
 
 \ /
  Last update: 2012-02-24 00:25    [from the cache]
©2003-2011 Jasper Spaans