lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 02/22/2012 12:18 AM, Ingo Molnar wrote:
> >
> > For example could you tell *at a glance* what this does:
> >
> > + if (!static_branch_def_false(&perf_sched_events.key))
> >
> > ?
>
> Yes. [...]

You have specially built eyes I guess - congrats, you are member
of the 1% :-)

> [...] Unlike
>
> > + if (very_unlikely(&perf_sched_events.key))
>
> ... which is actively misleading.

Misleading in what way? It clearly conveys that the slowpath
that follows is a slowpath, that what follows is 'very
unlikely'.

This is how all current kernel code is using these facilities.

If you have a new usecase (CPU feature flags) then you should
outline that, instead of expecting something of current usecases
that they are clearly not ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-02-22 16:53    [W:0.184 / U:2.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site