lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regmap: Append device name in the root debugfs dir
    On Wed, Feb 22, 2012 at 01:57:09PM +0000, Mark Brown wrote:
    > On Wed, Feb 22, 2012 at 01:53:03PM +0000, Dimitris Papastamos wrote:
    >
    > > void regmap_debugfs_init(struct regmap *map)
    > > {
    > > - map->debugfs = debugfs_create_dir(dev_name(map->dev),
    > > - regmap_debugfs_root);
    > > + char name[64];
    >
    > That's a magic number, where did it come from?

    I can try to use something like NAME_MAX I suppose.

    > > +
    > > + snprintf(name, sizeof(name), "%s-%s",
    > > + dev_name(map->dev), map->dev->driver->name);
    > > +
    > > + map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);
    >
    > No, keep the directory name the same and add a new file.

    Right, that was what I had initially implemented but seemed a bit of
    overkill, but yea I can do that.

    Thanks,
    Dimitris


    \
     
     \ /
      Last update: 2012-02-22 15:03    [W:0.020 / U:30.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site