Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc_fdtable | Date | Wed, 22 Feb 2012 10:18:56 +0000 |
| |
Bobby Powers <bobbypowers@gmail.com> wrote:
> alloc_fdtable allocates space for the open_fds and close_on_exec > bitfields together, as 2 * nr / BITS_PER_BYTE. close_on_exec needs to > point to open_fds + nr / BITS_PER_BYTE, not open_fds + nr / > BITS_PER_LONG, as introducted in 1fd36adc: Replace the fd_sets in > struct fdtable with an array of unsigned longs. > > Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
Yes, you're right. At one point I changed data to be an unsigned long *.
Acked-by: David Howells <dhowells@redhat.com>
| |