lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 19/19] ARM: at91/board-dt: move at91_initialize() to init_irq()
    On Wed, Feb 22, 2012 at 10:39:45AM +0100, Nicolas Ferre wrote:
    > From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
    >
    > Remove the need for at91_initialize() to be called at init_early().
    > We move it to init_irq() function as we still need it before the
    > timer initialization.
    >
    > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
    > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

    NAK. Keep the callback methods pure. The whole point of the init_early
    is so that soc people don't end up polluting things like the IRQ
    initialization and timer initialization with stuff like this.

    So this is a backwards step.


    \
     
     \ /
      Last update: 2012-02-22 10:51    [W:0.022 / U:29.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site