lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] x86: Move per cpu cpu_llc_id to a field in struct cpuinfo_x86
    On Mon, Feb 20, 2012 at 10:06:03PM -0400, Kevin Winchester wrote:
    > This simplifies the various code paths using this field as it
    > groups the per-cpu data together.
    >
    > Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
    > ---
    > arch/x86/include/asm/processor.h | 2 ++
    > arch/x86/include/asm/smp.h | 2 --
    > arch/x86/kernel/apic/apic_numachip.c | 2 +-
    > arch/x86/kernel/cpu/amd.c | 14 ++++----------
    > arch/x86/kernel/cpu/common.c | 1 +
    > arch/x86/kernel/cpu/intel_cacheinfo.c | 11 ++---------
    > arch/x86/kernel/smpboot.c | 18 ++++++++----------
    > 7 files changed, 18 insertions(+), 32 deletions(-)
    >
    > diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
    > index 0c8b574..2d4eb6f 100644
    > --- a/arch/x86/include/asm/processor.h
    > +++ b/arch/x86/include/asm/processor.h
    > @@ -111,6 +111,8 @@ struct cpuinfo_x86 {
    > u16 cpu_index;
    > u32 microcode;
    > cpumask_t llc_shared_map;
    > + /* cpus sharing the last level cache: */

    Just a minor nitpick which I forgot: we spell "CPUs" in the comments as
    in the next patch you're adding a comment about the sibling_map.

    Thanks.

    --
    Regards/Gruss,
    Boris.


    \
     
     \ /
      Last update: 2012-02-21 11:43    [W:2.316 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site