lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: compat: autofs v5 packet size ambiguity - update
    From
    From: Linus Torvalds <torvalds@linux-foundation.org>
    Date: Tue, 21 Feb 2012 18:24:10 -0800

    > No, the problem is that "is_compat_task()" is not the right check.
    > It's not the task that *waits* for autofs that matters, it's that damn
    > autofs daemon task.
    >
    > IOW, what we actually want to test is whether the other end of that
    > autofs sbi->pipe is a compat task or not.
    >
    > And I have no idea how to do that.

    It's just a real fd, and there is no way to tell the compat'ness for
    that. The mount operation literally passes in an integer attribute as
    the pipefd mount option, and that's what it seems to use to send these
    events.

    And that fd can be dup()'d, exec()'d into compat and non-compat tasks,
    passed around as SCM credentials between arbitrary processes, etc.

    It's a real mess.

    The only way to fix this cess pool completely is to override the
    read() fop on that pipe, and translate the event stream in-situ.

    What we could do is just manage the autofs messages as a linked list
    of events, f.e. the packets in native format, then in the overridden
    read() handler we either pass it along as is (for non-compat tasks) or
    translate to compat format and copy that to userspace instead.


    \
     
     \ /
      Last update: 2012-02-22 04:19    [from the cache]
    ©2003-2011 Jasper Spaans