[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Linux 3.3-rc4
    Le mardi 21 février 2012 à 14:43 -0800, Linus Torvalds a écrit :
    > On Sun, Feb 19, 2012 at 5:42 AM, Thomas Meyer <> wrote:
    > >
    > > 2.) while debugging above issue: I did find an minor bug in sys_poll() - nobody did take care of my proposed patch:
    > Ok, so I started out forward-porting that patch to current -git
    > (trivial: it's just that the system call tables are differently
    > generated now), but the more I look at it, the more I suspect that we
    > should perhaps just globally fix "sys_poll()" to have the timeout
    > argument be 'int'.
    > Because that *is* the standard user interface (just do "man 2 poll"),
    > and while all of the git history (and all of the BK history) we've had
    > it as "long", I suspect we should just fix it.
    > So I suspect the correct patch is just as attached instead: make
    > sys_poll() just take an "int timeout". Any user who tried to use a
    > long value would already have got truncated by glibc - I just checked.
    > Of course, there is a remote possibility that somebody might not use
    > glibc, and have used "poll()" with the raw system call interface, and
    > depended on using a 64-bit "long timeout" on 64-bit architectures.
    > But quite frankly, that sounds rather unlikely in the extreme.
    > Comments? If we do this, and somebody actually reports that they use a
    > 64-bit timeout, we could always go back to the broken 'long' argument,
    > and take your patch to fix the compat case.
    > Linus

    Yep, this is what I thought, but when this was raised last september,
    both Andrew and Andi disagreed.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-02-22 00:13    [W:0.021 / U:20.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site