[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[tip:x86/urgent] x86: Specify a size for the cmp in the NMI handler
    Commit-ID:  a38449ef596b345e13a8f9b7d5cd9fedb8fcf921
    Author: Steven Rostedt <>
    AuthorDate: Mon, 20 Feb 2012 15:29:34 -0500
    Committer: Steven Rostedt <>
    CommitDate: Mon, 20 Feb 2012 19:45:26 -0500

    x86: Specify a size for the cmp in the NMI handler

    Linus noticed that the cmp used to check if the code segment is
    __KERNEL_CS or not did not specify a size. Perhaps it does not matter
    as H. Peter Anvin noted that user space can not set the bottom two
    bits of the %cs register. But it's best not to let the assembly choose
    and change things between different versions of gas, but instead just
    pick the size.

    Four bytes are used to compare the saved code segment against
    __KERNEL_CS. Perhaps this might mess up Xen, but we can fix that when
    the time comes.

    Also I noticed that there was another non-specified cmp that checks
    the special stack variable if it is 1 or 0. This too probably doesn't
    matter what cmp is used, but this patch uses cmpl just to make it non


    Suggested-by: Linus Torvalds <>
    Cc: H. Peter Anvin <>
    Signed-off-by: Steven Rostedt <>
    arch/x86/kernel/entry_64.S | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
    index debd851..1333d98 100644
    --- a/arch/x86/kernel/entry_64.S
    +++ b/arch/x86/kernel/entry_64.S
    @@ -1535,14 +1535,14 @@ ENTRY(nmi)
    * If %cs was not the kernel segment, then the NMI triggered in user
    * space, which means it is definitely not nested.
    - cmp $__KERNEL_CS, 16(%rsp)
    + cmpl $__KERNEL_CS, 16(%rsp)
    jne first_nmi

    * Check the special variable on the stack to see if NMIs are
    * executing.
    - cmp $1, -8(%rsp)
    + cmpl $1, -8(%rsp)
    je nested_nmi


     \ /
      Last update: 2012-02-21 23:11    [W:0.032 / U:7.360 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site