lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regulator: Clean up debugfs error handling a bit
    On 2/20/2012 1:15 PM, Mark Brown wrote:
    > Use IS_ERR_OR_NULL() rather than open coding it and ignore errors from
    > failure to create the supply map.

    Reported-by: Stephen Boyd <sboyd@codeaurora.org>

    >
    > Signed-off-by: Mark Brown<broonie@opensource.wolfsonmicro.com>

    >
    > @@ -3231,14 +3231,13 @@ static int __init regulator_init(void)
    >
    > #ifdef CONFIG_DEBUG_FS
    > debugfs_root = debugfs_create_dir("regulator", NULL);
    > - if (IS_ERR(debugfs_root) || !debugfs_root) {
    > + if (IS_ERR_OR_NULL(debugfs_root)) {
    > pr_warn("regulator: Failed to create debugfs directory\n");
    > debugfs_root = NULL;
    > }
    >
    > - if (IS_ERR(debugfs_create_file("supply_map", 0444, debugfs_root,
    > - NULL,&supply_map_fops)))
    > - pr_warn("regulator: Failed to create supplies debugfs\n");
    > + debugfs_create_file("supply_map", 0444, debugfs_root, NULL,
    > + &supply_map_fops);

    Do you want an else here so that if the regulator directory fails we
    don't accidentally create a supply_map file in the root of debugfs? How
    ever unlikely that sounds.


    \
     
     \ /
      Last update: 2012-02-21 07:43    [W:0.020 / U:61.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site