Messages in this thread | | | Date | Tue, 21 Feb 2012 09:35:38 -0500 | From | Jason Baron <> | Subject | Re: [PATCH 0/4][RFC] jump label: introduce default true branch |
| |
On Mon, Feb 20, 2012 at 11:51:41PM +0100, Peter Zijlstra wrote: > On Mon, 2012-02-20 at 14:47 -0800, H. Peter Anvin wrote: > > On 12/21/2011 11:09 AM, Jason Baron wrote: > > > Hi Peter, > > > > > > I've introduced a new static_branch_def_true() construct, such that the straight > > > line path is the true branch, and we patch a jump to get to the false branch. > > > In order to make jump_label_inc()/dec() work as 'make true'/'make false' with > > > counting, I've had to update some of the core jump label code. This patchset also > > > introduces: JUMP_LABEL_INIT_TRUE/FALSE, so that keys should be initialized as: > > > > > > struct jump_label_key true_key = JUMP_LABEL_INIT_TRUE; > > > > > > or > > > > > > struct jump_label_key false_key = JUMP_LABEL_INIT_FALSE; > > > > > > I think this patch series should address the issues that came up with sched_feat() > > > implementation. > > > > > > > Hi, > > > > Did this ever get addressed? > > I actually tried to push that stuff to Ingo, he figured it all should > have different names. Jason and Ingo went back and forth for a while and > afaik settled on something. Jason then went off to implement, but I > haven't yet seen a new version. > >
I'll post a patch series later today.
Thanks,
-Jason
| |