Messages in this thread | | | Date | Tue, 21 Feb 2012 09:19:24 -0500 | Subject | Re: [PATCH v2 3/3] i387: support lazy restore of FPU state | From | Josh Boyer <> |
| |
On Tue, Feb 21, 2012 at 12:27 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Mon, Feb 20, 2012 at 6:14 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> On 02/20/2012 06:10 PM, Linus Torvalds wrote: >>> >>> Although I do wonder if we should just make kernel_fpu_begin() be a >>> real function instead of inlining it. I'm not sure it makes sense to >>> inline that thing, and it might be better to export that one instead. >>> Comments? >> >> I would agree with that. > > So I have a patch that does that, but it's noticeably bigger. > > It uninlines a fair amount of i387.h, and moves it into i387.c. I do > think it's probably the right thing to do, though. > > I did a "make allmodconfig" with this on x86-64, but it's quite > possible that x86-32 does additional cases. Does this patch work for > people? > > (This is *on*top*of* the quick "let's just get it to work" patch that > just exports the new percpu variable. I already committed that and > pushed it out, since I wanted a quick fix so that people wouldn't be > held up by this) > > IOW, if you can try this on top of current -git, that would be lovely.
The quick patch cleared up the build issue I was seeing. Thanks for the quick fix. I'll try building with this one a bit later today as well.
josh
| |