lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] HID: wacom: fix proximity tool release
    On Sun, 19 Feb 2012, Przemo Firszt wrote:

    > Don't zero the current tool before reporting its release to the input
    > subsystem.
    >
    > Signed-off-by: Aristeu Rozanski <aris@redhat.com>
    > Tested-by: Przemo Firszt <przemo@firszt.eu>
    > ---
    > drivers/hid/hid-wacom.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
    > index 0621047..696b907 100644
    > --- a/drivers/hid/hid-wacom.c
    > +++ b/drivers/hid/hid-wacom.c
    > @@ -322,10 +322,10 @@ static void wacom_i4_parse_pen_report(struct wacom_data *wdata,
    >
    > switch (data[1]) {
    > case 0x80: /* Out of proximity report */
    > - wdata->tool = 0;
    > input_report_key(input, BTN_TOUCH, 0);
    > input_report_abs(input, ABS_PRESSURE, 0);
    > input_report_key(input, wdata->tool, 0);
    > + wdata->tool = 0;
    > input_sync(input);
    > break;
    > case 0xC2: /* Tool report */

    I have put this into my upstream-fixes branch. I think this should go into
    3.3 still.

    Thanks,

    --
    Jiri Kosina
    SUSE Labs


    \
     
     \ /
      Last update: 2012-02-21 14:29    [W:0.021 / U:1.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site