lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] x86: s/#if CONFIG/#ifdef CONFIG/

* Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>"
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: x86@kernel.org
> ---
> arch/x86/boot/compressed/head_32.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
> index a055993..a37b117 100644
> --- a/arch/x86/boot/compressed/head_32.S
> +++ b/arch/x86/boot/compressed/head_32.S
> @@ -173,7 +173,7 @@ relocated:
> call decompress_kernel
> addl $20, %esp
>
> -#if CONFIG_RELOCATABLE
> +#ifdef CONFIG_RELOCATABLE
> /*
> * Find the address of the relocations.
> */

I'd really prefer to read an actual "this is safe, because this
value is defined in the Kconfig as ..." type of commit log
instead of nothing, which would ensure us that you didnt just do
a (fundamentally unsafe) sed job over the kernel tree but
actually have *read* the Kconfig entries in question to ensure
the correctness of your patches...

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-02-20 09:29    [from the cache]
©2003-2011 Jasper Spaans