lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()
On Thu 16-02-12 11:13:53, Sage Weil wrote:
> On Thu, 16 Feb 2012, Alex Elder wrote:
> > On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote:
> > > CC: Sage Weil <sage@newdream.net>
> > > CC: ceph-devel@vger.kernel.org
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> >
> >
> > This will update the timestamp even if a write
> > fault fails, which is different from before.
> >
> > Hard to avoid though.
> >
> > Looks good to me.
>
> Yeah. Let's put something in the tracker to take a look later (I think we
> can do better), but this is okay for now.
>
> Signed-off-by: Sage Weil <sage@newdream.net>
Thanks! Just an administrative note - the tag above should rather be
Acked-by or Reviewed-by. You'd use Signed-off-by only if you took the patch
and merged it via your tree... So can I add Acked-by?

Honza

> > Signed-off-by: Alex Elder <elder@dreamhost.com>
> >
> > > fs/ceph/addr.c | 3 +++
> > > 1 files changed, 3 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> > > index 173b1d2..12b139f 100644
> > > --- a/fs/ceph/addr.c
> > > +++ b/fs/ceph/addr.c
> > > @@ -1181,6 +1181,9 @@ static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
> > > loff_t size, len;
> > > int ret;
> > >
> > > + /* Update time before taking page lock */
> > > + file_update_time(vma->vm_file);
> > > +
> > > size = i_size_read(inode);
> > > if (off + PAGE_CACHE_SIZE <= size)
> > > len = PAGE_CACHE_SIZE;
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2012-02-20 23:45    [from the cache]
©2003-2011 Jasper Spaans