lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag
    From
    On Mon, Feb 20, 2012 at 1:23 PM, Tejun Heo <tj@kernel.org> wrote:
    > On Mon, Feb 20, 2012 at 01:16:27PM -0800, Brian Norris wrote:
    >> On Mon, Feb 20, 2012 at 12:51 PM, Tejun Heo <tj@kernel.org> wrote:
    >> > Overall the patchset looks good but
    >> >
    >> > On Mon, Feb 20, 2012 at 12:09:21PM -0800, Brian Norris wrote:
    >> >> +     AHCI_HFLAG_STRICT_SPEC          = (1 << 15), /* strict AHCI spec */
    >> >
    >> > can you please use something more specific?  e.g. something like
    >> > SKIP_ENGINE_ON_PORT_START and then explain what the flag is about in
    >> > the comment?
    >>
    >> So you want AHCI_HFLAG_SKIP_ENGINE_ON_PORT_START? That seems
    >> excessively long... how about AHCI_HFLAG_DELAY_ENGINE? (since it
    >> pushes the start engine call back to the error-handling stage)
    >
    > Ooh, yeah, that seems better.  I'm fine with any name which ties it to
    > engine behavior on port start.

    OK. I'll wait a bit for other comments, then send a v2 series with
    AHCI_HFLAG_DELAY_ENGINE.

    Brian
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-20 23:09    [W:0.028 / U:2.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site