lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag
    Hello,

    Overall the patchset looks good but

    On Mon, Feb 20, 2012 at 12:09:21PM -0800, Brian Norris wrote:
    > + AHCI_HFLAG_STRICT_SPEC = (1 << 15), /* strict AHCI spec */

    can you please use something more specific? e.g. something like
    SKIP_ENGINE_ON_PORT_START and then explain what the flag is about in
    the comment?

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-02-20 21:53    [W:0.020 / U:0.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site