Messages in this thread | | | Date | Mon, 20 Feb 2012 12:51:15 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag |
| |
Hello,
Overall the patchset looks good but
On Mon, Feb 20, 2012 at 12:09:21PM -0800, Brian Norris wrote: > + AHCI_HFLAG_STRICT_SPEC = (1 << 15), /* strict AHCI spec */
can you please use something more specific? e.g. something like SKIP_ENGINE_ON_PORT_START and then explain what the flag is about in the comment?
Thanks.
-- tejun
| |