lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [tip:x86/urgent] x86/nmi: Test saved %cs in NMI to determine nested NMI case
On Mon, Feb 20, 2012 at 3:47 AM, tip-bot for Steven Rostedt
<rostedt@goodmis.org> wrote:
>        /*
> +        * If %cs was not the kernel segment, then the NMI triggered in user
> +        * space, which means it is definitely not nested.
> +        */
> +       cmp $__KERNEL_CS, 16(%rsp)
> +       jne first_nmi

I don't like how you wrote 'cmp' without a size, especially with none
of the arguments then giving a size either. Usually there's a register
name or something that gives you the size, but not here.

I guess there is some default size that gas will use, but at least
some versions of gas have traditionally errored out instead of
guessing on sizes. Maybe x86-64 doesn't use those gas versions any
more, but still..

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-02-20 19:05    [W:0.065 / U:3.792 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site