lkml.org 
[lkml]   [2012]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] TTY: use tty_standard_install
On Mon, Jan 30, 2012 at 09:14:30PM +0100, Jiri Slaby wrote:
> Use the helper in the rest of the tty drivers. This is a simple
> replacement.

It would be, if you actually built this patch, as it is, it breaks :(

>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Acked-by: Alan Cox <alan@linux.intel.com>
> ---
> drivers/isdn/capi/capi.c | 9 +++------
> drivers/misc/pti.c | 6 +-----
> drivers/mmc/card/sdio_uart.c | 9 +++------
> drivers/tty/nozomi.c | 8 ++------
> 4 files changed, 9 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
> index e44933d..ca9261a 100644
> --- a/drivers/isdn/capi/capi.c
> +++ b/drivers/isdn/capi/capi.c
> @@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
> {
> int idx = tty->index;
> struct capiminor *mp = capiminor_get(idx);
> - int ret = tty_init_termios(tty);
> + int ret = tty_standard_install(tty);

This, and, all of the other calls in this patch, should be (driver, tty)
for the function arguments, right?

That seems to fix the build for me, so I've checked it in, but please
verify that I got it right.

greg k-h


\
 
 \ /
  Last update: 2012-02-03 00:13    [from the cache]
©2003-2011 Jasper Spaans