lkml.org 
[lkml]   [2012]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -v2 0/7] PCI: pcie hotplug related patch
    From
    On Thu, Feb 2, 2012 at 2:00 AM, Kenji Kaneshige
    <kaneshige.kenji@jp.fujitsu.com> wrote:
    > Yinghai, Jesse,
    >
    > I tested pciehp with your set of patches. I have some comments below.
    >
    > (1) I got a following warning message on compiling the patch [5/7].
    >
    >    drivers/pci/hotplug/pciehp_hpc.c:281: warning:
    > 'pcie_wait_link_not_active' defined but not used
    >
    > (2) I got following warning messages on compiling the patch [6/7]
    >
    >    drivers/pci/hotplug/pciehp_hpc.c:381: warning: 'pciehp_link_enable'
    > defined but not used
    >    drivers/pci/hotplug/pciehp_hpc.c:386: warning: 'pciehp_link_disable'
    > defined but not used
    >
    > (3) I've asked Naoki Yanagimoto, who reported that configuration read
    >    on some hot-added PCIe device returns invalid value, to test the
    >    patch. Unfortunately, the problem happens with your patch. But
    >    after some discussion and testing, it turned out that problem doesn't
    >    happen when the same card with updated bios is used. So it seems the
    >    problem is in PCIe card side.
    >
    > As a result, problems I found are (1) and (2). Please fix those.
    > Other than that, pciehp seems to work well.
    >
    > Tested-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
    >

    Great. thanks for confirmation.

    for (1) and (2), patch 5, and 6 will add some helper functions and
    they will be used by patch 7.

    so when patch 7 is applied, there will be no compiling warning anymore.

    Thanks

    Yinghai
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-02 21:41    [W:0.020 / U:0.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site