Messages in this thread | | | Date | Thu, 2 Feb 2012 09:17:27 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH] PM/Hibernate: Refactor and simplify freezer_test_done |
| |
On Thu, Feb 02, 2012 at 07:10:19AM +0530, Srivatsa S. Bhat wrote: > @@ -251,10 +251,10 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd, > error = hibernation_snapshot(data->platform_support); > if (!error) { > error = put_user(in_suspend, (int __user *)arg); > - if (!error && !freezer_test_done) > - data->ready = 1; > if (freezer_test_done) > freezer_test_done = false; > + else if (!error) > + data->ready = 1;
Hmmm... how about..
data->ready = !freezer_test_done && !error; freezer_test_done = false;
-- tejun
| |