lkml.org 
[lkml]   [2012]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM/Hibernate: Refactor and simplify freezer_test_done
On Thu, Feb 02, 2012 at 07:10:19AM +0530, Srivatsa S. Bhat wrote:
> @@ -251,10 +251,10 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd,
> error = hibernation_snapshot(data->platform_support);
> if (!error) {
> error = put_user(in_suspend, (int __user *)arg);
> - if (!error && !freezer_test_done)
> - data->ready = 1;
> if (freezer_test_done)
> freezer_test_done = false;
> + else if (!error)
> + data->ready = 1;

Hmmm... how about..

data->ready = !freezer_test_done && !error;
freezer_test_done = false;

--
tejun


\
 
 \ /
  Last update: 2012-02-02 18:19    [W:0.078 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site