Messages in this thread | | | Date | Thu, 2 Feb 2012 15:53:53 +0100 | From | Wolfram Sang <> | Subject | Re: [rtc-linux] Re: [PATCH v3] rtc: ds1307: generalise ram size and offset |
| |
Hi Austin,
> I'm sorry about the slow response - I was away at linux.conf.au and then > haven't found enough time since I got back.
Don't worry, I understand.
> > ... that nvram is static and we are changing it. Yeah, it is very unlikely but > > if we have two RTC with different nvram sizes, one of them will not work correctly. > I see the issue. Am I right that it would only occur when you have two > I2C buses, each with one of the RTC chips supported by this driver?
Basically yes. They could be on one bus, though, using different addresses.
> The fix I thought of would be to add a 'struct bin_attribute' pointer to > 'struct ds1307' and then in the probe function allocate the structure, > set the size & callbacks, and pass it as an argument to > sysfs_create_bin_file. Do you think this is viable?
Yes.
> It looks like Andrew Morton has already added this patch to the -mm > tree. Has he also grabbed the patches that this depends on?
I will check that and mail him later today.
Thanks,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |