lkml.org 
[lkml]   [2012]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH v2][GIT PULL][v3.3] x86: Test saved %cs in NMI to determine nested NMI
From
Date

Ingo,

I rebased the same branch so you may need to wait a little for the
kernel.org mirrors to update.

Please pull the latest tip/perf/urgent tree, which can be found at:

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
tip/perf/urgent

Head SHA1: 38f53faa02c0976ed0a6f0290771a4cbe6dc655b


Steven Rostedt (1):
x86: Test saved %cs in NMI to determine nested NMI

----
arch/x86/kernel/entry_64.S | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
---------------------------
commit 38f53faa02c0976ed0a6f0290771a4cbe6dc655b
Author: Steven Rostedt <srostedt@redhat.com>
Date: Sat Feb 18 20:26:52 2012 -0500
x86: Test saved %cs in NMI to determine nested NMI

Currently, the NMI handler tests if it is nested by checking the
special variable saved on the stack (set during NMI handling) and
whether the saved stack is the NMI stack as well (to prevent the race
when the variable is set to zero). But userspace may set their %rsp
to any value as long as they do not derefence it, and it may make it
point to the NMI stack, which will prevent NMIs from triggering while
the userspace app is running. (I tested this, and it is indeed the case)

Add another check to determine nested NMIs by looking at the saved
%cs (code segment register) and making sure that it is the kernel code segment.

Cc: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index 3fe8239..debd851 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -1532,6 +1532,13 @@ ENTRY(nmi)
pushq_cfi %rdx

/*
+ * If %cs was not the kernel segment, then the NMI triggered in user
+ * space, which means it is definitely not nested.
+ */
+ cmp $__KERNEL_CS, 16(%rsp)
+ jne first_nmi
+
+ /*
* Check the special variable on the stack to see if NMIs are
* executing.
*/



\
 
 \ /
  Last update: 2012-02-19 22:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site