lkml.org 
[lkml]   [2012]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 08/30] compat: Use COMPAT_USE_64BIT_TIME in the lp driver
On Sun, Feb 19, 2012 at 4:07 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> From: "H. J. Lu" <hjl.tools@gmail.com>
>
> Enable the lp driver to be used with a compat ABI with 64-bit time.

Ugh. Is this really the only case?

Because if it isn't, I suspect it would be much better off with a
helper function. In fact, even if this *does* end up being the only
place, a helper function to get/set a timeval from user space sounds
like a good idea, and makes things much more readable than that
ad-hoccery in the middle of code.

IOW, I'd like to see something like

get_user_timeval(void __user *tv, struct timeval *res)

even if it would be only local to this file.

Linus


\
 
 \ /
  Last update: 2012-02-20 01:59    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site